apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Published 20 hours ago • verified publisher icon commons-app

"Copy to subsequent media" does not work if depicts Wikidata place

Open nicolas-raoul opened this issue 3 years ago • 18 comments

Steps to reproduce:

  1. Take several pictures near a Wikidata place
  2. Upload both together.
  3. When asked whether the pictures depict the place, say yes.
  4. Write a caption/description
  5. Tap "Copy to subsequent media"
  6. Tap "Next"
  7. Expected: The caption/description from step 4 has not been copied. Problem: The caption/description is from the Wikidata place.

Workaround: Tap "Previous" and tap "Copy to subsequent media" again. This time it works.

nicolas-raoul avatar Sep 23 '22 06:09 nicolas-raoul

Hi, I cannot recreate this bug - tried both 4.0 release and master versions.

Select existing place -> upload images -> click yes -> delete name and description that has been copied into fields -> enter name / description -> copy to subsequent media -> upload -> next image contains copied fields.

DamienBradleyDSP avatar Oct 11 '22 12:10 DamienBradleyDSP

Interesting, there may be special conditions I have not thought of.

nicolas-raoul avatar Oct 11 '22 14:10 nicolas-raoul

Hi @nicolas-raoul Could I please work on this issue? Pls assign me. Thank you:)

junhaow1 avatar Oct 21 '22 02:10 junhaow1

@junhaow1 Yes thanks! First, please let us know whether you are able to reproduce the issue.

nicolas-raoul avatar Oct 23 '22 02:10 nicolas-raoul

Can I work on these issue if @junhaow1 not working ?

arinmodi avatar Dec 26 '22 15:12 arinmodi

@arinmodi Feel free to work on it, thanks!

nicolas-raoul avatar Jan 03 '23 13:01 nicolas-raoul

@nicolas-raoul, not able to reproduce

arinmodi avatar Jan 04 '23 18:01 arinmodi

@nicolas-raoul When I reproduce the issue, I am not getting any bug occurrence. The captions and description is getting copied to the whole batch without having tapped the previous. Am I missing something here?

ayushanand308 avatar Feb 27 '23 12:02 ayushanand308

When setting the development environment, I am getting the following errors. Is there any way out?

Screenshot 2023-02-27 164022

ayushanand308 avatar Feb 27 '23 12:02 ayushanand308

@ayushanand308 For such errors I recommend searching the web for these error messages.

nicolas-raoul avatar Feb 27 '23 12:02 nicolas-raoul

@arinmodi @ayushanand308 I just tried and was able to reproduce the issue the first time. Make sure you are getting the popup at step 3. If not, edit the pictures' EXIF to be at the location of the Eiffel Tower, then select both and share to the Commons app.

nicolas-raoul avatar Feb 27 '23 12:02 nicolas-raoul

@nicolas-raoul I followed what you said and was able to successfully reproduce the issue.

ayushanand308 avatar Feb 27 '23 21:02 ayushanand308

@ayushanand308 Great! Do you want to be assigned to this issue? 🙂

nicolas-raoul avatar Feb 28 '23 00:02 nicolas-raoul

@nicolas-raoul Yes!

ayushanand308 avatar Feb 28 '23 09:02 ayushanand308

@ayushanand308 It is yours! Please let us know about your progress every few days. Thanks! :-)

nicolas-raoul avatar Feb 28 '23 13:02 nicolas-raoul

Is this how it is actually supposed to work? https://user-images.githubusercontent.com/99035102/222404635-dbdeb5fb-677d-4904-9c4a-88ff6fd316df.mp4

ayushanand308 avatar Mar 02 '23 10:03 ayushanand308

Yes exactly 🙂

nicolas-raoul avatar Mar 02 '23 10:03 nicolas-raoul

@nicolas-raoul I have made a PR. Can you kindly review it. :-).

ayushanand308 avatar Mar 05 '23 18:03 ayushanand308