apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Use coordinates2country instead of Geocoder in UploadMediaPresenter

Open nicolas-raoul opened this issue 3 years ago • 2 comments

UploadMediaPresenter.java uses Geocoder in the reverseGeoCode method. This usage has several problems:

  • Requires a geocoding backend such as Google Play Services, which is not always available and reliable (example).
  • Apparently uses the network.
  • Possibly a Wikimedia privacy violation, as Geocoder sends the user's picture location to a third-party service.

We already use a small offline geocoding library, it could be used for this too. We only need the country, not full address.

nicolas-raoul avatar Sep 21 '22 08:09 nicolas-raoul

Hello @nicolas-raoul, may I take a look at this issue?

DKolibar avatar Oct 10 '22 09:10 DKolibar

@DKolibar Yes, it is yours, thanks!

nicolas-raoul avatar Oct 10 '22 11:10 nicolas-raoul

@nicolas-raoul I created PR #5093 for this issue. I hope my implementation is as expected.

DKolibar avatar Oct 23 '22 17:10 DKolibar