apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Location edit - allow to center on GPS provided location

Open matkoniecz opened this issue 2 years ago • 4 comments

What is the user problem or growth opportunity you want to see solved?

User should not be expected to scroll to their current location through half the world

How do you know that this problem exists today? Why is this important?

I just tried to add location and have up

Screenshot_20220709-185242

Who will benefit from it?

People adding location to uploads

Anything else you would like to add?

No response

matkoniecz avatar Jul 09 '22 16:07 matkoniecz

Yes, the first time you are dropped at a random location in San Francisco, but then the app remembers the last location you chose 🙂

Adding a "center on location" button like in Google Maps is a great idea, there is a good probability that it will be nearer to where the picture was taken than San Francisco. Please note that using GPS often results in permission issues, so it might not be trivial to implement&test though.

nicolas-raoul avatar Aug 06 '22 07:08 nicolas-raoul

there is a good probability that it will be nearer to where the picture was taken than San Francisco

and also likely closer than the last remembered location!

matkoniecz avatar Aug 06 '22 08:08 matkoniecz

@matkoniecz I would like to take on this issue.

russianbear222 avatar Oct 13 '22 22:10 russianbear222

Feel free to work on it (as far as I am concerned - and it seems that noone else is working on it)

matkoniecz avatar Oct 14 '22 07:10 matkoniecz

Hi, is this issue closed? @mattflaschen

russianbear222 avatar Oct 23 '22 04:10 russianbear222

@pwq334107948 Have you noticed that this issue is already assigned to @russianbear222 ? Hopefully you two can collaborate (for instance to add unit tests) but in the future please make sure the issue is assigned to you before starting coding 🙂

@russianbear222 Feel free to pull pwq's code and improve it, thanks!

nicolas-raoul avatar Oct 23 '22 09:10 nicolas-raoul

@matkoniecz I added a new pull request, however, I wasn't able to do unit tests, I don't understand its format.

russianbear222 avatar Oct 26 '22 06:10 russianbear222

@nicolas-raoul I fixed the things you mentioned.

russianbear222 avatar Oct 29 '22 12:10 russianbear222