apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Published 20 hours ago • verified publisher icon commons-app

[Bug]: F-Droid: GMS libs in the final apk

Open linsui opened this issue 3 years ago • 2 comments

Summary

F-Droid deploys a new binary scanner which finds GMS in the apk. See https://gitlab.com/linsui/fdroiddata/-/jobs/2577487197 I don't know where it comes from.

Steps to reproduce

You can use dexdump and grep to check the apk.

Expected behaviour

There is no nonfree libs.

Actual behaviour

GMS sleaks in.

Device name

No response

Android version

_

Commons app version

Since 2.6.5

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

No response

linsui avatar Jun 13 '22 13:06 linsui

Thanks for letting us know about this!

nicolas-raoul avatar Jun 14 '22 00:06 nicolas-raoul

It's via mapbox, there are references in com/mapbox/android/core/location/

Any chance to update to https://github.com/maplibre/maplibre-gl-native instead of the old lib?

Ref: https://github.com/maplibre/maplibre-gl-native/pull/313

/LE: I tried to replace it locally (kept telemetry plugin since there's no -libre equivalent), and exclude gms, but it fails to build: Unresolved reference: Timber in some kotlin files

licaon-kter avatar Jun 14 '22 10:06 licaon-kter

The Timber error sounds like something that could be solved with some Gradle wizardry maybe?

nicolas-raoul avatar Nov 08 '22 00:11 nicolas-raoul

@nicolas-raoul Hi, can I take this up?

bhavanagarlapati avatar Dec 06 '22 08:12 bhavanagarlapati

@bhavanagarlapati Yes, please let us know about your progress every two or three days, thanks! :-)

nicolas-raoul avatar Dec 07 '22 08:12 nicolas-raoul