apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Fixed #4835 : [Bug]: Multi-upload continues even after pausing all

Open arinmodi opened this issue 2 years ago • 2 comments

Description (required)

Fixes #4835

What changes did you make and why?

Just check for the upload that if it's already paused or not

Tests performed (required)

Tested build variant on ASUS_X00TD with API level 28

arinmodi avatar Mar 20 '22 05:03 arinmodi

@nicolas-raoul, Sorry for the delay on this issue, can you please review this now ?

arinmodi avatar Mar 20 '22 05:03 arinmodi

Codecov Report

Merging #4905 (ffb1686) into master (fa03704) will decrease coverage by 0.13%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4905      +/-   ##
============================================
- Coverage     50.87%   50.74%   -0.14%     
+ Complexity     2249     2245       -4     
============================================
  Files           340      340              
  Lines         15710    15712       +2     
  Branches       1382     1383       +1     
============================================
- Hits           7993     7973      -20     
- Misses         7114     7141      +27     
+ Partials        603      598       -5     
Impacted Files Coverage Δ
...w/commons/contributions/ContributionsFragment.java 31.71% <0.00%> (-0.21%) :arrow_down:
.../fr/free/nrw/commons/upload/worker/UploadWorker.kt 20.00% <ø> (ø)
...a/fr/free/nrw/commons/OkHttpConnectionFactory.java 52.27% <0.00%> (-20.46%) :arrow_down:
...a/fr/free/nrw/commons/review/ReviewController.java 79.06% <0.00%> (-12.80%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa03704...ffb1686. Read the comment docs.

codecov[bot] avatar Mar 20 '22 05:03 codecov[bot]