apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

[Bug]: Only one category shows for a depicted item if it has several values on P373

Open Ainali opened this issue 3 years ago • 11 comments

Summary

I noticed on Q636666 that it did not show the category I expected. It turns out that it has two values on P373 and the one that unfortunately is hard to interpret for me is chosen in the app.

Steps to reproduce

  1. Upload an image
  2. In depicts, select an item with several values on P373
  3. In categories, see that only one of them is shown

Expected behaviour

I would like to see all values as suggested categories.

Actual behaviour

The app suggests one of the categories, not all.

Device name

Samsung Galaxy S10

Android version

Android 12

Commons app version

3.1.1~1c9267ca0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

No response

Ainali avatar Mar 15 '22 11:03 Ainali

Interestingly the DepictedItem class already has commonsCategories: List<CategoryItem>, we should verify that:

  • It is filled correctly
  • We surface all of its elements as suggestions, not just the first element.

nicolas-raoul avatar Mar 16 '22 05:03 nicolas-raoul

I made this screencast:

https://user-images.githubusercontent.com/5566159/158545266-d4f06992-6a3d-4fe2-a8a9-13969e7d8314.mp4

Interestingly it shows a category Ventura (ship), which doesn't exist. The name of the other category on Wikidata which exists on Commons, and the one I expected, is Ventura (ship, 2008).

Ainali avatar Mar 16 '22 08:03 Ainali