apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

"Oh, this is not even categorized!" on image with 1 category

Open nicolas-raoul opened this issue 3 years ago • 4 comments

Summary

Despite https://commons.wikimedia.org/w/index.php?title=File:Stamp_of_Ajman_-1968-Colnect_682825-Ferdinand_of_Austria-by_Velasquez_and-_Return_from_hunting.jpeg&action=history having a category (and having it since it was first created), I got the following screen in Review:

adb

Steps to reproduce

Open Review Review until you get Oh, this is not even categorized! If it actually does not have categories, try again

Expected behaviour

should not display this message if there is at least one category

Actual behaviour

displays message despite 1 category

Device name

No response

Android version

9

Commons app version

master

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Prefer not

nicolas-raoul avatar Mar 02 '22 01:03 nicolas-raoul

Should I do it in my existing PR itself? It is part of it. Thanks : )

devarsh-mavani-19 avatar Mar 02 '22 02:03 devarsh-mavani-19

Thanks for showing interest @devarsh-mavani-19, we recommend solving each issue in a different PR.

4D17Y4 avatar Mar 04 '22 16:03 4D17Y4

Thanks for showing interest @devarsh-mavani-19, we recommend solving each issue in a different PR.

@4D17Y4 sorry for delay in responding. Actually adding this feature https://github.com/commons-app/apps-android-commons/pull/4874 Will automatically solve this issue as well.

devarsh-mavani-19 avatar Mar 05 '22 05:03 devarsh-mavani-19

Despite https://commons.wikimedia.org/w/index.php?title=File:Stamp_of_Ajman_-1968-Colnect_682825-Ferdinand_of_Austria-by_Velasquez_and-_Return_from_hunting.jpeg&action=history having a category (and having it since it was first created), I got the following screen in Review:

May be this is related to https://github.com/commons-app/apps-android-commons/issues/4901 ? I say that because the picture linked above has a single category ("1968 stamps of Ajman") that starts with a date. If that's the case, #4902 should fix this too. [ I hope to get around to fixing those tests soon :) ].

sivaraam avatar Apr 10 '22 16:04 sivaraam