Refactor: wikidta models

[ben-mathu]

Part of an ongoing code refactoring to move all models to a common models package.

Fixes #4782

Moved wikidata models to data.models package.

Tested debug on Pixel 4 (Emulator) with API level 30.

[codecov[bot]]

Codecov Report

Merging #4871 (1ba2fcf) into master (0d25c24) will decrease coverage by 0.93%. The diff coverage is n/a.

:exclamation: Current head 1ba2fcf differs from pull request most recent head 27ccc65. Consider uploading reports for the commit 27ccc65 to get more accurate results

@@             Coverage Diff              @@
##             master    #4871      +/-   ##
============================================
- Coverage     51.42%   50.48%   -0.94%     
+ Complexity     2327     2217     -110     
============================================
  Files           345      336       -9     
  Lines         16194    15538     -656     
  Branches       1430     1359      -71     
============================================
- Hits           8327     7844     -483     
+ Misses         7236     7110     -126     
+ Partials        631      584      -47     

Impacted Files	Coverage Δ
...ee/nrw/commons/explore/depictions/DepictsClient.kt	90.90% <ø> (ø)
...r/free/nrw/commons/explore/media/MediaConverter.kt	71.42% <ø> (+0.31%)	:arrow_up:
...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java	16.20% <ø> (ø)
...ree/nrw/commons/upload/depicts/DepictsPresenter.kt	72.36% <ø> (+10.04%)	:arrow_up:
...ommons/upload/structure/depictions/DepictedItem.kt	91.52% <ø> (ø)
...a/fr/free/nrw/commons/wikidata/WikidataClient.java	100.00% <ø> (ø)
...free/nrw/commons/wikidata/WikidataEditService.java	26.82% <ø> (-2.77%)	:arrow_down:
...ain/java/fr/free/nrw/commons/auth/AccountUtil.java	83.33% <0.00%> (-16.67%)	:arrow_down:
...fr/free/nrw/commons/settings/SettingsFragment.java	41.17% <0.00%> (-16.04%)	:arrow_down:
...n/java/fr/free/nrw/commons/upload/UploadModel.java	25.58% <0.00%> (-11.57%)	:arrow_down:
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bb2cbc...27ccc65. Read the comment docs.

[ben-mathu]

There is an issue with the code in master @madhurgupta10

[madhurgupta10]

There is an issue with the code in master @madhurgupta10

Correct, I have created an issue for this (https://github.com/commons-app/apps-android-commons/issues/4927) hope it gets resolved soon.

[neslihanturan]

Hi, is this PR sleeping @ben-mathu ?:)

[psh]

This (and the other 10 PR's associated with refactoring model classes) seem to have stalled since February. Is this work that is wanted or fair to call it abandoned? If the work is needed, you want me to pull the changes onto a single feature branch get the tests cleaned up and submit a single PR that could be reviewed and merged so these 11 can be closed?

[misaochan]

Hi @psh , nice to see you again! :) Unfortunately testing and reviewing large refactors is probably not something that we have the capacity for at the moment. As the PR authors have not gotten back to us, I would actually suggest closing all the stale PRs, and we can revisit the issue and take up your offer in the future if we have a reviewer who can volunteer their time for it. @neslihanturan what do you think?