apps-android-commons
apps-android-commons copied to clipboard
Refactor: utils models
Part of an ongoing code refactoring to move all models to a common models package.
Fixes #4782
Moved utils models to data.models package.
Tested debug on Pixel 4 (Emulator) with API level 30.
Codecov Report
Merging #4870 (03065b5) into master (0d25c24) will decrease coverage by
1.00%
. The diff coverage isn/a
.
:exclamation: Current head 03065b5 differs from pull request most recent head edb1cad. Consider uploading reports for the commit edb1cad to get more accurate results
@@ Coverage Diff @@
## master #4870 +/- ##
============================================
- Coverage 51.42% 50.41% -1.01%
+ Complexity 2327 2215 -112
============================================
Files 345 338 -7
Lines 16194 15546 -648
Branches 1430 1359 -71
============================================
- Hits 8327 7837 -490
+ Misses 7236 7124 -112
+ Partials 631 585 -46
Impacted Files | Coverage Δ | |
---|---|---|
...java/fr/free/nrw/commons/utils/DeviceInfoUtil.java | 77.77% <ø> (ø) |
|
...n/java/fr/free/nrw/commons/utils/NetworkUtils.java | 80.00% <ø> (ø) |
|
...ain/java/fr/free/nrw/commons/auth/AccountUtil.java | 83.33% <0.00%> (-16.67%) |
:arrow_down: |
...fr/free/nrw/commons/settings/SettingsFragment.java | 41.17% <0.00%> (-16.04%) |
:arrow_down: |
.../nrw/commons/category/CategoryContentProvider.java | 12.50% <0.00%> (-14.29%) |
:arrow_down: |
...w/commons/upload/categories/BaseDelegateAdapter.kt | 35.29% <0.00%> (-11.77%) |
:arrow_down: |
...n/java/fr/free/nrw/commons/upload/UploadModel.java | 25.58% <0.00%> (-11.57%) |
:arrow_down: |
...a/fr/free/nrw/commons/wikidata/WikiBaseClient.java | 23.52% <0.00%> (-11.48%) |
:arrow_down: |
...ava/fr/free/nrw/commons/review/ReviewActivity.java | 47.28% <0.00%> (-10.06%) |
:arrow_down: |
...r/free/nrw/commons/review/ReviewImageFragment.java | 25.80% <0.00%> (-5.88%) |
:arrow_down: |
... and 30 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2bb2cbc...edb1cad. Read the comment docs.
Hi, is this PR sleeping @ben-mathu ?:)