apps-android-commons
apps-android-commons copied to clipboard
Refactor: QuizQuestion model
Part of an ongoing code refactoring to move all models to a common models package.
Fixes #4782
Moved QuizQuestion to data.models package.
Tested debug on Pixel 4 (Emulator) with API level 30.
Codecov Report
Merging #4868 (eaf893f) into master (87b9648) will decrease coverage by
0.23%
. The diff coverage isn/a
.
:exclamation: Current head eaf893f differs from pull request most recent head aadea08. Consider uploading reports for the commit aadea08 to get more accurate results
@@ Coverage Diff @@
## master #4868 +/- ##
============================================
- Coverage 50.66% 50.43% -0.24%
+ Complexity 2231 2217 -14
============================================
Files 338 337 -1
Lines 15531 15542 +11
Branches 1358 1359 +1
============================================
- Hits 7869 7838 -31
- Misses 7079 7120 +41
- Partials 583 584 +1
Impacted Files | Coverage Δ | |
---|---|---|
...in/java/fr/free/nrw/commons/quiz/QuizActivity.java | 62.16% <ø> (ø) |
|
.../java/fr/free/nrw/commons/quiz/QuizController.java | 100.00% <ø> (ø) |
|
...fr/free/nrw/commons/review/ReviewPagerAdapter.java | 30.76% <0.00%> (-38.47%) |
:arrow_down: |
...r/free/nrw/commons/explore/media/MediaConverter.kt | 71.42% <0.00%> (-23.81%) |
:arrow_down: |
...a/fr/free/nrw/commons/review/ReviewController.java | 79.06% <0.00%> (-12.80%) |
:arrow_down: |
...ree/nrw/commons/contributions/ContributionDao.java | 6.25% <0.00%> (-12.50%) |
:arrow_down: |
...commons/contributions/ContributionsRepository.java | 41.66% <0.00%> (-8.34%) |
:arrow_down: |
.../java/fr/free/nrw/commons/review/ReviewHelper.java | 77.77% <0.00%> (-5.56%) |
:arrow_down: |
...ns/contributions/ContributionsLocalDataSource.java | 16.66% <0.00%> (-4.17%) |
:arrow_down: |
...ava/fr/free/nrw/commons/review/ReviewActivity.java | 47.28% <0.00%> (-3.11%) |
:arrow_down: |
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 87b9648...aadea08. Read the comment docs.
Hi, is this PR sleeping @ben-mathu ?:)