apps-android-commons
apps-android-commons copied to clipboard
Refactor: profile models
Part of an ongoing code refactoring to move all models to a common models package.
Fixes #4782
Moved profile models to data.models package.
Tested debug on Pixel 4 (Emulator) with API level 30.
Codecov Report
Merging #4867 (5965612) into master (87b9648) will decrease coverage by
0.22%. The diff coverage isn/a.
:exclamation: Current head 5965612 differs from pull request most recent head 5552219. Consider uploading reports for the commit 5552219 to get more accurate results
@@ Coverage Diff @@
## master #4867 +/- ##
============================================
- Coverage 50.66% 50.44% -0.23%
+ Complexity 2231 2196 -35
============================================
Files 338 333 -5
Lines 15531 15460 -71
Branches 1358 1358
============================================
- Hits 7869 7799 -70
+ Misses 7079 7076 -3
- Partials 583 585 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java | 16.20% <ø> (ø) |
|
| ...ons/profile/achievements/AchievementsFragment.java | 67.54% <ø> (ø) |
|
| ...w/commons/profile/achievements/FeedbackResponse.kt | 0.00% <ø> (ø) |
|
| ...w/commons/profile/leaderboard/DataSourceClass.java | 0.00% <ø> (ø) |
|
| ...commons/profile/leaderboard/DataSourceFactory.java | 0.00% <ø> (ø) |
|
| ...mmons/profile/leaderboard/LeaderboardFragment.java | 46.03% <ø> (ø) |
|
| ...ns/profile/leaderboard/LeaderboardListAdapter.java | 44.44% <ø> (ø) |
|
| .../profile/leaderboard/LeaderboardListViewModel.java | 0.00% <ø> (ø) |
|
| ...commons/profile/leaderboard/UserDetailAdapter.java | 0.00% <ø> (ø) |
|
| ...fr/free/nrw/commons/review/ReviewPagerAdapter.java | 30.76% <0.00%> (-38.47%) |
:arrow_down: |
| ... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 87b9648...5552219. Read the comment docs.