apps-android-commons
apps-android-commons copied to clipboard
Refactor: media models
Part of an ongoing code refactoring to move all models to a common models package.
Fixes #4782
Moved media models to data.models package.
Tested debug on Pixel 4 (Emulator) with API level 30.
Codecov Report
Merging #4864 (0d7021f) into master (87b9648) will decrease coverage by
0.14%. The diff coverage isn/a.
:exclamation: Current head 0d7021f differs from pull request most recent head 60d2591. Consider uploading reports for the commit 60d2591 to get more accurate results
@@ Coverage Diff @@
## master #4864 +/- ##
============================================
- Coverage 50.66% 50.51% -0.15%
+ Complexity 2231 2221 -10
============================================
Files 338 336 -2
Lines 15531 15537 +6
Branches 1358 1359 +1
============================================
- Hits 7869 7849 -20
- Misses 7079 7103 +24
- Partials 583 585 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ain/java/fr/free/nrw/commons/MediaDataExtractor.kt | 18.18% <ø> (ø) |
|
| ...free/nrw/commons/media/CaptionListViewAdapter.java | 20.00% <ø> (ø) |
|
| ...fr/free/nrw/commons/media/CommonsWikibaseItem.java | 0.00% <ø> (ø) |
|
| ...fr/free/nrw/commons/media/MediaDetailFragment.java | 34.10% <ø> (ø) |
|
| ...fr/free/nrw/commons/review/ReviewPagerAdapter.java | 30.76% <0.00%> (-38.47%) |
:arrow_down: |
| ...r/free/nrw/commons/explore/media/MediaConverter.kt | 71.42% <0.00%> (-23.81%) |
:arrow_down: |
| ...ree/nrw/commons/contributions/ContributionDao.java | 6.25% <0.00%> (-12.50%) |
:arrow_down: |
| ...commons/contributions/ContributionsRepository.java | 41.66% <0.00%> (-8.34%) |
:arrow_down: |
| .../java/fr/free/nrw/commons/review/ReviewHelper.java | 77.77% <0.00%> (-5.56%) |
:arrow_down: |
| ...ns/contributions/ContributionsLocalDataSource.java | 16.66% <0.00%> (-4.17%) |
:arrow_down: |
| ... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 87b9648...60d2591. Read the comment docs.
Hi, is this PR sleeping @ben-mathu ?:)