apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Refactor: customselector models

Open ben-mathu opened this issue 3 years ago • 1 comments

Part of an ongoing code refactoring to move all models to a common models package.

Fixes #4782

Moved custom selector model to data.models package.

Tested debug on Pixel 4 (Emulator) with API level 30.

ben-mathu avatar Feb 25 '22 11:02 ben-mathu

Codecov Report

Merging #4856 (90153c4) into master (87b9648) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 90153c4 differs from pull request most recent head 770d64b. Consider uploading reports for the commit 770d64b to get more accurate results

@@             Coverage Diff              @@
##             master    #4856      +/-   ##
============================================
- Coverage     50.66%   50.65%   -0.02%     
+ Complexity     2231     2226       -5     
============================================
  Files           338      337       -1     
  Lines         15531    15522       -9     
  Branches       1358     1358              
============================================
- Hits           7869     7862       -7     
+ Misses         7079     7077       -2     
  Partials        583      583              
Impacted Files Coverage Δ
...nrw/commons/customselector/database/UploadedDao.kt 33.33% <ø> (ø)
...e/nrw/commons/customselector/helper/ImageHelper.kt 28.57% <ø> (ø)
...commons/customselector/ui/adapter/FolderAdapter.kt 72.00% <ø> (ø)
.../commons/customselector/ui/adapter/ImageAdapter.kt 83.33% <ø> (ø)
...stomselector/ui/selector/CustomSelectorActivity.kt 78.82% <ø> (ø)
...tomselector/ui/selector/CustomSelectorViewModel.kt 86.66% <ø> (ø)
...mmons/customselector/ui/selector/FolderFragment.kt 74.35% <ø> (ø)
...mons/customselector/ui/selector/ImageFileLoader.kt 82.00% <ø> (ø)
...ommons/customselector/ui/selector/ImageFragment.kt 60.00% <ø> (ø)
.../commons/customselector/ui/selector/ImageLoader.kt 78.64% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87b9648...770d64b. Read the comment docs.

codecov[bot] avatar Feb 25 '22 14:02 codecov[bot]