FIXING ISSUE #4711 Make the app more accessible - content description

Open Rishavgupta12345 opened this issue 2 years ago • 10 comments

FIXING a part of ISSUE #4471

UPDATE:- LATEST COMMIT DONE IN THIS PULL REQUEST solves the issue completely

Jan 25 '22 14:01 Rishavgupta12345

done all the necessary files changes for this issue. Now merging this pull request will close the issue @nicolas-raoul

Jan 26 '22 13:01 Rishavgupta12345

Codecov Report

Merging #4766 (ac8e262) into master (7e12d28) will decrease coverage by 0.10%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4766      +/-   ##
============================================
- Coverage     40.31%   40.20%   -0.11%     
  Complexity     1809     1809              
============================================
  Files           364      364              
  Lines         15735    15733       -2     
  Branches       1363     1363              
============================================
- Hits           6343     6326      -17     
- Misses         8927     8943      +16     
+ Partials        465      464       -1

Impacted Files	Coverage Δ
.../fr/free/nrw/commons/upload/worker/UploadWorker.kt	`13.81% <0.00%> (-6.19%)`	:arrow_down:
...r/free/nrw/commons/explore/media/MediaConverter.kt	`92.85% <0.00%> (-2.39%)`	:arrow_down:
...w/commons/contributions/ContributionsFragment.java	`31.59% <0.00%> (ø)`
...ava/fr/free/nrw/commons/upload/UploadActivity.java	`62.79% <0.00%> (+0.57%)`	:arrow_up:
.../fr/free/nrw/commons/widget/PicOfDayAppWidget.java	`66.00% <0.00%> (+2.00%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e12d28...ac8e262. Read the comment docs.

Jan 26 '22 20:01 codecov[bot]

should I have to do something now ? I have no idea with this codecov report @nicolas-raoul

Jan 27 '22 06:01 Rishavgupta12345

That's only XML changes, so please do not worry about codecov. Hopefully someone with accessibility knowledge (=not me) will review your PR. Meanwhile feel free to work on other if you want. :-)

Jan 27 '22 10:01 nicolas-raoul

That's only XML changes, so please do not worry about codecov. Hopefully someone with accessibility knowledge (=not me) will review your PR. Meanwhile feel free to work on other if you want. :-)

pull request opened from many days , who will review it and merge it

Feb 15 '22 14:02 Rishavgupta12345

The best person to review this is @neslihanturan , however she has been busy recently working on one of our features. She should be done soon hopefully, and will have time to review then. Please be patient @Rishavgupta12345 . :)