apps-android-commons
apps-android-commons copied to clipboard
FIXING ISSUE #4711 Make the app more accessible - content description
FIXING a part of ISSUE #4471
UPDATE:- LATEST COMMIT DONE IN THIS PULL REQUEST solves the issue completely
done all the necessary files changes for this issue. Now merging this pull request will close the issue @nicolas-raoul
Codecov Report
Merging #4766 (ac8e262) into master (7e12d28) will decrease coverage by
0.10%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #4766 +/- ##
============================================
- Coverage 40.31% 40.20% -0.11%
Complexity 1809 1809
============================================
Files 364 364
Lines 15735 15733 -2
Branches 1363 1363
============================================
- Hits 6343 6326 -17
- Misses 8927 8943 +16
+ Partials 465 464 -1
Impacted Files | Coverage Δ | |
---|---|---|
.../fr/free/nrw/commons/upload/worker/UploadWorker.kt | 13.81% <0.00%> (-6.19%) |
:arrow_down: |
...r/free/nrw/commons/explore/media/MediaConverter.kt | 92.85% <0.00%> (-2.39%) |
:arrow_down: |
...w/commons/contributions/ContributionsFragment.java | 31.59% <0.00%> (ø) |
|
...ava/fr/free/nrw/commons/upload/UploadActivity.java | 62.79% <0.00%> (+0.57%) |
:arrow_up: |
.../fr/free/nrw/commons/widget/PicOfDayAppWidget.java | 66.00% <0.00%> (+2.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e12d28...ac8e262. Read the comment docs.
should I have to do something now ? I have no idea with this codecov report @nicolas-raoul
That's only XML changes, so please do not worry about codecov. Hopefully someone with accessibility knowledge (=not me) will review your PR. Meanwhile feel free to work on other if you want. :-)
That's only XML changes, so please do not worry about codecov. Hopefully someone with accessibility knowledge (=not me) will review your PR. Meanwhile feel free to work on other if you want. :-)
pull request opened from many days , who will review it and merge it
The best person to review this is @neslihanturan , however she has been busy recently working on one of our features. She should be done soon hopefully, and will have time to review then. Please be patient @Rishavgupta12345 . :)
@4D17Y4 my this pull request is open for many days , so you may review this if you can
Thanks for letting us know @Rishavgupta12345, in the meantime you can work on other PRs/Issues.
Hİ @Rishavgupta12345 , is this PR still active?:)
Hİ @Rishavgupta12345 , is this PR still active?:)
yes, it is active. I was working on my GSOC proposal and college exams so there was a delay , I will work on this soon