apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Fixed #4758: "Info" tooltip not visible in Japanese because of long label

Open vivek-gite opened this issue 3 years ago • 2 comments

Description (required)

Fixes #4758

What changes did you make and why?

Changed the Japanese translation of "Step %1$d to %2d"

Tested on: samsung a20 API level 30

Screenshots (for UI changes only) image

vivek-gite avatar Jan 19 '22 11:01 vivek-gite

Codecov Report

Merging #4761 (17bbe17) into master (852d195) will increase coverage by 0.14%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4761      +/-   ##
============================================
+ Coverage     40.17%   40.31%   +0.14%     
- Complexity     1794     1808      +14     
============================================
  Files           363      364       +1     
  Lines         15626    15735     +109     
  Branches       1346     1363      +17     
============================================
+ Hits           6277     6343      +66     
- Misses         8885     8926      +41     
- Partials        464      466       +2     
Impacted Files Coverage Δ
...upload/mediaDetails/UploadMediaDetailFragment.java 76.07% <0.00%> (-5.47%) :arrow_down:
...pload/categories/UploadCategoryAdapterDelegates.kt 18.18% <0.00%> (-4.90%) :arrow_down:
...in/java/fr/free/nrw/commons/category/Category.java 62.06% <0.00%> (-4.60%) :arrow_down:
...commons/upload/structure/depictions/DepictModel.kt 14.28% <0.00%> (-3.37%) :arrow_down:
...ategory/CategoryEditSearchRecyclerViewAdapter.java 10.81% <0.00%> (-0.79%) :arrow_down:
...in/java/fr/free/nrw/commons/mwapi/CategoryApi.java 12.19% <0.00%> (ø)
...ava/fr/free/nrw/commons/upload/GpsCategoryModel.kt 100.00% <0.00%> (ø)
.../fr/free/nrw/commons/utils/StringSortingUtils.java 92.30% <0.00%> (ø)
...w/commons/contributions/ContributionsFragment.java 31.59% <0.00%> (ø)
...commons/upload/categories/UploadCategoryAdapter.kt 83.33% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 852d195...17bbe17. Read the comment docs.

codecov[bot] avatar Jan 26 '22 20:01 codecov[bot]

Hi @vivek-gite , is this PR still active?

neslihanturan avatar Apr 25 '22 18:04 neslihanturan