apps-android-commons
apps-android-commons copied to clipboard
Fixes 4745 : Add bookmarked items to suggested depictions
Description (required)
Fixes #4745
What changes did you make and why?
Since bookmarked items are probably things that the user has an interest in, I append them when suggesting depictions.
Tests performed (required)
Tested ProdDebug on Pixel 3 with API level 30.
Codecov Report
Merging #4746 (da0a759) into master (6e8bd4b) will decrease coverage by
0.07%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #4746 +/- ##
============================================
- Coverage 51.42% 51.34% -0.08%
+ Complexity 2327 2322 -5
============================================
Files 345 345
Lines 16194 16195 +1
Branches 1430 1430
============================================
- Hits 8327 8315 -12
- Misses 7236 7254 +18
+ Partials 631 626 -5
Impacted Files | Coverage Δ | |
---|---|---|
...ree/nrw/commons/upload/depicts/DepictsPresenter.kt | 59.71% <66.66%> (-2.61%) |
:arrow_down: |
...a/fr/free/nrw/commons/OkHttpConnectionFactory.java | 52.27% <0.00%> (-20.46%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6e8bd4b...da0a759. Read the comment docs.
I will start reviewing this after https://github.com/commons-app/apps-android-commons/pull/4725 (which is higher priority) is perfected and merged, thanks for both! :-)
@nicolas-raoul As #4725 is merged, you can review it now.