apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

fix issue Hard to tell if we are looking at a scrolling list

Open Prince-kushwaha opened this issue 3 years ago • 4 comments

Description (required)

Fixes #4513

What changes did you make and why? Added vertical scrollbar to all instances of RecyclerView so that when the underlying list is populated and overflows the view a scrollbar temporarily appears indicating to the user that scrolling is possible

Tests performed (required)

Tested {ProdDebug} }.

Screenshots (for UI changes only) Screenshot_1639564065

Prince-kushwaha avatar Dec 15 '21 10:12 Prince-kushwaha

Thanks! Would you mind solving the conflict?

nicolas-raoul avatar Dec 22 '21 09:12 nicolas-raoul

Codecov Report

Merging #4734 (419ec95) into master (8a0d558) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 419ec95 differs from pull request most recent head b4ad81c. Consider uploading reports for the commit b4ad81c to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4734   +/-   ##
=========================================
  Coverage     40.02%   40.02%           
  Complexity     1763     1763           
=========================================
  Files           358      358           
  Lines         15328    15328           
  Branches       1324     1324           
=========================================
  Hits           6135     6135           
  Misses         8742     8742           
  Partials        451      451           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a0d558...b4ad81c. Read the comment docs.

codecov[bot] avatar Dec 24 '21 10:12 codecov[bot]

@nicolas-raoul can review this PR

Prince-kushwaha avatar Dec 28 '21 15:12 Prince-kushwaha

Hİ @Prince-kushwaha , is this PR still active?:)

neslihanturan avatar Apr 25 '22 18:04 neslihanturan