commons-app
Use different icon for login and about page
Would it be better to use this logo instead of the current logo as the title is already included in the logo.
Old logo:
New logo:
The only problem that I would have with the new logo though is that the spacing between the title and icon is a bit too small.
Honestly, the 2nd one looks a bit squashed to me, haha. What benefit would having the title in the logo confer?
Yeah I agree. Mainly the title logo combo was proposed as to keep consistent with the rest of the Wikimedia Commons brand.
I suppose better styling of the text in the first screenshot could be done. Would it be better to have the title as "Wikimedia Commons" or keep it as just "Commons"?
We discussed that some time ago at #196 , and I think the conclusion was that we would use "Commons" within the app itself and "Wikimedia Commons" for external links (e.g. listings on Google Play and F Droid). So I think that means "Commons" as the title. But we are open to changes if anyone feels otherwise. :)
From reading #196, it appears that it was agreed upon that the launcher should read "Commons" for the sake of no text clipping (which is understandable). However from what I've read it doesn't seem that there was any mention as to what the name should be inside the app. Personally I would vote to use "Wikimedia Commons" everywhere (e.g. on Google Play, inside the app) but for the launcher call it "Commons".
Ah, good point. I'm personally fine with either "Wikimedia Commons" or "Commons" for the login page. @nicolas-raoul what do you think?
I would say the second, actually. Better font, and that's where people need to trust the app with their password, so better show the full name.
Cheers! Nicolas Raoul
On Wed, Mar 15, 2017 at 12:32 AM, Josephine Lim [email protected] wrote:
Ah, good point. I'm personally fine with either "Wikimedia Commons" or "Commons" for the login page. @nicolas-raoul https://github.com/nicolas-raoul what do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/433#issuecomment-286459078, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFBsQqkQuLmx4P6y0TIr87X9iYwgitks5rlrMagaJpZM4Marqr .
I think veyndan is offering to "replicate" the second one by modifying the text beneath the first screenshot, but keeping the padding. How does that option sound?
Any updates on which one to use. I can see the point of @nicolas-raoul so I'm favouring that atm.
@veyndan I think https://en.wikipedia.org/wiki/Wikipedia:Be_bold also applies to our development spirit. So if no one has strong opposition to your favored change, I think you should submit it.
@veyndan , any chance of the new icon being ready within the next day or so? If not, no worries, I can just put it in the next release.
I am having a bit of a problem with changing the text of the icon based on the theme. A couple of solutions that I can think of is having two drawables, one for the light and one for the dark or just tint one icon.
I may get some time later on to do it.
@veyndan Hi, Veyndan.
Not sure whether this ever got incorporated into the app; could you confirm?
Thanks,
Chris.
