Upload error when point (.) in name

[nicolas-raoul]

Steps to reproduce:

0. Set FakeGPS (or equivalent) to be near this music venue: https://goo.gl/maps/go8ncPKxnDQgWTAD8
1. Compile the app using the "structured-data" branch (not sure if needed)
2. Start the app
3. Go to "Nearby"
4. Select the item 渋谷La.mama https://www.wikidata.org/wiki/Q64778538
5. Try to upload this picture for it:
6. Upload error:

Notice also the truncated name 渋谷La. I have not experienced this with any other item/picture, there must be something special with this one. Sorry I don't have a logcat. I have not tried on master either.

[macgills]

            return uploadInterface.uploadFileToStash(fileNameRequestBody, tokenRequestBody, filePart)
                    .map(stashUploadResponse -> stashUploadResponse.getUpload());

getUpload is null I would say this has nothing to do with structured data though I did test on it. Getting the error response from the API now

[macgills]

Right now I am guessing we should replace . with _

[macgills]

B-I-N-G-O

{
  "errors": [
    {
      "code": "verification-error",
      "text": "File extension \".mama\" does not match the detected MIME type of the file (image/jpeg).",
      "data": {
        "details": [
          "filetype-mime-mismatch",
          "mama",
          "image/jpeg"
        ]
      },
      "module": "upload"
    }
  ],
  "docref": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes.",
  "servedby": "mw1281"
}

[macgills]

And I'd wager for the second error

   @NonNull public String getDisplayTitle() {
        return filename != null ? getPageTitle().getDisplayTextWithoutNamespace().replaceFirst("[.][^.]+$", "") : "";
    }

this is the culprit

[macgills]

This is not related to structuredData so I will remove my assignment

[ashishkumar468]

Tagging @misaochan @neslihanturan @maskaravivek for suggestions

[misaochan]

Hmmm, I've never encountered this problem, it seems to be specifically for that particular Wikidata item?

[nicolas-raoul]

For all such Wikidata items I guess. Maybe use that item or rename the sandbox item momentarily, and before upload modify title (but not the label(s)) to prevent the problem seen at https://github.com/commons-app/apps-android-commons/issues/3651#issuecomment-613396737?

[shabar-shab]

@nicolas-raoul can I work on this?

[nicolas-raoul]

@shabar-shab Yes, thanks! Please let us know about your progress every few days :-)

[i-am-atif]

@nicolas-raoul can I work on this?

[shabar-shab]

@i-am-atif I was not able to reproduce this issue. did you reproduce this issue.

[i-am-atif]

@shabar-shab I just tried to reproduce this issue, but failed to do so

[i-am-atif]

I was able to upload the image without any error.

[nicolas-raoul]

@i-am-atif Did you follow all the steps exactly, especially step 4? Please post the URL of your uploaded image here, thanks!

[sotiriszogos]

Is this issue still open?

[nicolas-raoul]

@sotiriszogos Yes! The first step would be to try and reproduce it, possibly by using a sandbox item.

[sotiriszogos]

@nicolas-raoul Thank you, I will take a look by the end of the week to reproduce it and work on it if noone is currently working on this issue.

[nicolas-raoul]

@shabar-shab Are you still working on this? Please let us know about anything you have found out :-)

[jmora13]

Could I work on this? Is it still available?

[nicolas-raoul]

No answer from Shabar, so feel free to work on it @jmora13, thanks! Please let us know about your progress every few days :-)

[bhavanagarlapati]

Hi @nicolas-raoul Is anyone working on this issue? Can I take it up?

[samyak1326]

Hi @nicolas-raoul is anyone working on this issue?? I would like to take this up and work on it.

Thanks

[nicolas-raoul]

@samyak1326 Any progress on this? Did you manage to follow the reproduction steps? :-)

[samyak1326]

Hi @nicolas-raoul , yes, I was able to follow the steps and reproduce the error, and started working on the issue. It might take some more time to conclude. I will try my best.