apps-android-commons
apps-android-commons copied to clipboard
Replace toasts with snackbars where appropriate
Summary:
App uses toasts at many places which can be replaced by Snackbars for better UI.
Commons app version:
Latest master
Would you like to work on the issue?
Yes
Hi, i want to work on this issue.
@Tanvi-Goyal
Ah, sorry, Shridhar has mentioned Would you like to work on the issue? Yes
but we have forgotten to mark this issue as assigned
.
Can you find another unassigned issue?
Sorry about that!
I've already sent a PR which awaits a review.
@nicolas-raoul @ShridharGoel I suggest using CSnackBar Library for this task :)
@nicolas-raoul @4D17Y4 I want to work on this issue please assign me
@neslihanturan Do you think this is a good idea, actually? If yes, Rishav can work on it.
@madhurgupta10 Is a library really needed? The PR https://github.com/commons-app/apps-android-commons/pull/2389 does not seem to use any.
@nicolas-raoul External library not needed for this task. Also, we should not be replacing every single Toast with Snackbar
Links for reference https://stackoverflow.com/questions/34432339/android-snackbar-vs-toast-usage-and-difference
https://material.io/archive/guidelines/components/snackbars-toasts.html#:~:text=Snackbars%20contain%20a%20single%20line,not%20be%20swiped%20off%2Dscreen.
Lastly, if someone wants to work on this issue, please also update the unit tests accordingly.
@Rishavgupta12345 you already have quite a few issues assigned, if you still want to work on this task afterwards please ask again, thanks :-)
@nicolas-raoul @4D17Y4 work on previous issues is completed , please assign me this one