apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Check for whether username exists after signup button pressed

Open Ketharan opened this issue 7 years ago • 5 comments

Summary: When signing up through the app the checking for whether the user exists in the system done after pressing the signup button. Most of the times it ends up in multiple signup attempts.

Steps to reproduce: A signup with existing user name will reproduce.

Expected behavior:

The check up for the user existence should be checked after the 'onchange' trigger of the username field. Then the requirement for multiple attempts can be avoided.

Observed behavior: System check for the user existence after pressing the signup button requires to go through the entire signup process in case of the username exists.

Device and Android version: HUAWEI SCC U21 Android 5.0 (Anyway it does not matter which device or Android version as the activity is a webview)

Commons app version: 2.6.7

Ketharan avatar Mar 17 '18 19:03 Ketharan

@nicolas-raoul, should I take this up as a sub-task for #1298?

diddypod avatar Apr 01 '18 16:04 diddypod

I think it can be considered a different task :-) One may affect the other, though.

On Mon, Apr 2, 2018 at 1:08 AM, Suchit Kar [email protected] wrote:

@nicolas-raoul https://github.com/nicolas-raoul, should I take this up as a sub-task for #1298 https://github.com/commons-app/apps-android-commons/issues/1298?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/1325#issuecomment-377797125, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFBsOVJxhwHk_b_fVlih4YMWHwCxdQks5tkPtkgaJpZM4Su7uY .

nicolas-raoul avatar Apr 02 '18 05:04 nicolas-raoul

@nicolas-raoul Hi I would like to work on this, if no one is assigned to it.

aa-rikimaru avatar Apr 02 '18 18:04 aa-rikimaru

@aa-rikimaru OK it is yours :-)

nicolas-raoul avatar Apr 03 '18 06:04 nicolas-raoul

I've taken a look at it and I can't seem to find a way to check for an existing user in real-time unless I'm using AJAX calls. There are also methods in MediaWikiApi, such as validateLogin() that can be use, if the code for the SignUp button is located outside of WebView.

Should I wait for SignUpActivity to be an Activity? Or how can I add some Javascript inside?

aa-rikimaru avatar Apr 03 '18 21:04 aa-rikimaru