apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard
verified publisher icon commons-app

Adding gesture for navigation drawer

Open 97balakrishnan opened this issue 7 years ago • 5 comments

Summary:

swipe gesture to open navigation drawer on create account screen has not been added

Device and Android version:

Stock version of android 6.0

Commons app version:

2.6.7

97balakrishnan avatar Feb 14 '18 17:02 97balakrishnan

The Sign Up page seems to be a webView, so it's probably beyond the scope of the app to implement swipe gestures there. However, should we allow users to navigate through the site without logging in? If yes, we should put that option on the Log In screen.

diddypod avatar Feb 15 '18 11:02 diddypod

Yeah. I think that the entire create account page can be made into an android activity to ensure uniformity in the app.

97balakrishnan avatar Feb 15 '18 12:02 97balakrishnan

Can i start working on it?

97balakrishnan avatar Feb 15 '18 14:02 97balakrishnan

I'm okay with an Android activity being used to handle sign ups instead of the webview. I doubt that it will be an easy task, but anyone who is interested in working on it is certainly welcome to do so. :)

I am on the fence re: the nav drawer being accessible in the signup activity. Currently the app is built around the assumption that the user HAS to be logged in. Allowing non-logged in users to navigate the app would require a refactor of several other components AFAIK, and needs more discussion.

misaochan avatar Feb 15 '18 14:02 misaochan

okay. I will try doing this after discussions.

97balakrishnan avatar Feb 15 '18 15:02 97balakrishnan