commonmark-java icon indicating copy to clipboard operation
commonmark-java copied to clipboard

Published 20 hours ago • verified publisher icon commonmark

#255 handle dangling pipes

Open jk1 opened this issue 2 years ago • 1 comments

jk1 avatar Mar 01 '22 18:03 jk1

Hey, thanks for looking into this. Looking at what GitHub does (which we're trying to mirror with the extension), it renders this:

Abc|Def
---|---
1|2
|

Like this:

Abc Def
1 2

See how | is not actually part of the table anymore? Can you come up with a fix that handles it the same way?

robinst avatar Mar 03 '22 00:03 robinst

Hey @jk1 just checking in, have you seen my comment?

robinst avatar Oct 18 '22 05:10 robinst

Looked at it myself, the fix is a bit more involved, will raise a PR soon.

robinst avatar Oct 18 '22 07:10 robinst

PR: https://github.com/commonmark/commonmark-java/pull/268

robinst avatar Oct 18 '22 07:10 robinst

Hi @robinst thank you for the followup. I have seen the your comment back then, but didn't manage to implement what's requested. Things got wild really fast and was forced to flee my home country. Thanks a ton for getting back to this and providing a proper fix.

jk1 avatar Oct 19 '22 07:10 jk1

Hey! I'm so sorry to hear that, I can't imagine what that must be like. Hope things are looking better now.

robinst avatar Oct 19 '22 12:10 robinst