commonism

Results 106 comments of commonism

> @commonism Your contribution is licensed under the MIT license. It explicitly allows merging code without attribution. I thought this was MIT-0, but well, can you point me to somewhere...

MIT-0 is "zero attribution", the license here is MIT. I was not aware MIT can be read as merge-without-attribution as well and was asking for an explanation of this.

The Swagger 2.0 REST API requires a client with oauth https://github.com/ORCID/orcid-model/blob/master/src/main/resources/record_2.1/README.md#rest-api-reference https://pub.orcid.org/v3.0/ https://pub.orcid.org/resources/swagger.json https://api.orcid.org/v2.1/#/ https://api.orcid.org/resources/swagger.json

Hi, please consider adding renewalInfo to Directory to have it validated by josepy. ```python class Directory(acme.messages.Directory): renewalInfo: str = josepy.Field("renewalInfo", omitempty=True) """ Automated Certificate Management Environment (ACME) Renewal Information (ARI)...

I do not expect nanoseconds being a problem here, pyrfc3339 does those, they get dropped, but the loss in precision is not relevant. ``` >>> a = "2025-02-11T21:19:27.333333334Z" >>> pyrfc3339.parse(a)...

@Dreamsorcerer can you help me figure out the issue with the codecov/ checks? I can see it ran the unit tests, but failed to create proper coverage files? e.g. https://app.codecov.io/gh/aio-libs/yarl/pull/1026/blob/tests/test_url.py#L859

> I'd change the fail option to true, then it'll be obvious if any uploads have failed (and which jobs need to be rerun): https://github.com/aio-libs/yarl/blob/master/.github/workflows/ci-cd.yml#L340 It's not an upload failing....

> > Yet the only tests which are run evaluated are the tests which have a annotation to return None > > Oh, that's because webknjaz added mypy coverage to...

To my understanding … The coverage reported by [mypy](https://app.codecov.io/gh/aio-libs/yarl/pull/1026/tree?flags%5B0%5D=MyPy) is "[tests/test_url.py](https://app.codecov.io/gh/aio-libs/yarl/pull/1026/blob/tests/test_url.py?flags%5B0%5D=MyPy)", the coverage reported by [python 3.12.4](https://app.codecov.io/gh/aio-libs/yarl/pull/1026/tree?search=&flags%5B0%5D=Py-3.12.4) is for "[test_url.py](https://app.codecov.io/gh/aio-libs/yarl/pull/1026/blob/test_url.py)". The reported codecov numbers are combined values for unit testing...

Tried v3.1.4 - https://github.com/aio-libs/yarl/actions/runs/9691011881/job/26741939301 Can't say anything about the results as uploading fails due to rate limiting - https://github.com/codecov/codecov-action/issues/1293 may be related.