schema_salad

schema_salad copied to clipboard

https://www.commonwl.org/v1.1/SchemaSalad.html#Short_names Good for evaluating the `symbols` field of `{Command,}{Input,Output}EnumSchema`s Actual fix for https://github.com/common-workflow-lab/cwljava/issues/70 is to implement this and for callers to use the short name method on the elements of...

mr-c

metaschema predicates pollute salad document namespace

8

Alternative title: CWL enum `symbols` get fully expanded instead of being left as pure strings Source issue: https://github.com/common-workflow-lab/cwljava/issues/70 For example, `CommandInputEnumSchema` https://github.com/common-workflow-language/cwl-v1.2/blob/a0f2d38e37ff51721fdeaf993bb2ab474b17246b/CommandLineTool.yml#L355 extends `InputEnumSchema` https://github.com/common-workflow-language/cwl-v1.2/blob/a0f2d38e37ff51721fdeaf993bb2ab474b17246b/Process.yml#L689 which extends `sld:EnumSchema`https://github.com/common-workflow-language/cwl-v1.2/blob/a0f2d38e37ff51721fdeaf993bb2ab474b17246b/salad/schema_salad/metaschema/metaschema_base.yml#L135 which defines...

mr-c

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003977 Regardless of command line options, an external resource (picturefil js) is always referenced. Additionally, not providing `--brandstyle` leads to an external resource (bootstrap js) being used: https://github.com/common-workflow-language/schema_salad/blob/661fb0fa8c745ed70253dda93bd12002007f6b33/schema_salad/makedoc.py#L522 We should...

mr-c

## Problem As @mr-c discovered, documentation strings generated by the Java and TypeScript (and perhaps also Python?) codegen link to the wrong pages. ## Example: https://common-workflow-lab.github.io/cwl-ts-auto/classes/CommandLineTool.html contains a link to:...

ZimmerA

There are no descriptions of how to behave in the case of `"_id": "@type"`

2

The [schema of CWL](https://github.com/common-workflow-language/cwl-v1.2/blob/c0c31c54412619d106e100bfe70a49831a673004/Process.yml#L901) uses the following `jsonldPredicate` but there are no descriptions how `"_id": "@type"` field must be used for preprocessing. ```yaml jsonldPredicate: "_id": "@type" "_type": "@vocab" ``` It...

tom-tan

The [spec of `$include`](https://www.commonwl.org/v1.2/SchemaSalad.html#Include) says: > The URI string must be resolved to an absolute URI using the link resolution rules described previously. The URI referenced by `$include` must be...

tom-tan

I've tried loading and saving [conformance test 139](https://github.com/common-workflow-language/cwl-v1.2/blob/60a963508acafee8d6b024dcb9b0eaca255a49d5/conformance_tests.yaml#L1954) with models generated by the python codegen for the cwl 1.2.1_proposed schema, which resuled in the following output: ```CWL #!/usr/bin/env cwl-runner cwlVersion:...

ZimmerA

[Codegen] Remove redundancies in interfaces generated by the Java and TypeScript codegens

1

Currently, the Interfaces generated by the Java and TypeScript codegens contain redundancies in their fields caused by fields being passed down the inheritance hierarchy of the classes by the codegen....

ZimmerA

Currently, types marked as optional (using the `?:` notation) still contain the undefined type. This does not cause any issues but is also redundant. To fix this, the `type_loader` [function](https://github.com/ZimmerA/schema_salad/blob/3ee2ceb51fc8ddbd1aa791d4f0c6d7465acbe200/schema_salad/typescript_codegen.py#L379)...

ZimmerA

It is not clear the relationship between Salad documents and document contexts

4

The [section 2.3 in the spec](https://www.commonwl.org/v1.2/SchemaSalad.html#Document_context) describes two kinds of document contexts: implied context and explicit context. It seems that the Salad documents are written in either implied context or...

tom-tan