schema_salad icon indicating copy to clipboard operation
schema_salad copied to clipboard

[Codegen] Documentation strings contain wrong links

Open ZimmerA opened this issue 3 years ago • 0 comments

Problem

As @mr-c discovered, documentation strings generated by the Java and TypeScript (and perhaps also Python?) codegen link to the wrong pages.

Example:

https://common-workflow-lab.github.io/cwl-ts-auto/classes/CommandLineTool.html contains a link to: https://w3id.org/cwl/cwl#CommandLineTool when it actually should link to https://www.commonwl.org/v1.2/CommandLineTool.html#CommandLineTool

Affected Code

These strings get generated by the following lines:

TypeScript:

https://github.com/common-workflow-language/schema_salad/blob/74e909b532c7c5b12480421f9cfd06b3d7e24704/schema_salad/typescript_codegen.py#L162 https://github.com/common-workflow-language/schema_salad/blob/74e909b532c7c5b12480421f9cfd06b3d7e24704/schema_salad/typescript_codegen.py#L205 https://github.com/common-workflow-language/schema_salad/blob/74e909b532c7c5b12480421f9cfd06b3d7e24704/schema_salad/typescript_codegen.py#L737

Java:

https://github.com/common-workflow-language/schema_salad/blob/74e909b532c7c5b12480421f9cfd06b3d7e24704/schema_salad/java_codegen.py#L190 https://github.com/common-workflow-language/schema_salad/blob/74e909b532c7c5b12480421f9cfd06b3d7e24704/schema_salad/java_codegen.py#L196 https://github.com/common-workflow-language/schema_salad/blob/74e909b532c7c5b12480421f9cfd06b3d7e24704/schema_salad/java_codegen.py#L794

ZimmerA avatar Jan 06 '22 12:01 ZimmerA