cwlviewer icon indicating copy to clipboard operation
cwlviewer copied to clipboard

document running mvn test + docker compose

Open mr-c opened this issue 3 years ago • 19 comments

diff --git a/docker-compose.yml b/docker-compose.yml
index d0d8d6e..6bd31ae 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -38,6 +38,8 @@ services:
     restart: always
     image: mongo:3.4
     command: mongod --setParameter="internalQueryExecMaxBlockingSortBytes=335544320"
+    ports:
+     - "27017:27017"
     volumes:
       - type: volume
         source: mongo
@@ -45,8 +47,8 @@ services:
   sparql:
     restart: always
 ## For debugging, expose the Fuseki port by enabling:
-#    ports:
-#     - "3030:3030"
+    ports:
+     - "3030:3030"
 ## To find the admin password, try:
 ##   docker-compose exec sparql grep admin /fuseki/shiro.ini
     image: stain/jena-fuseki:3.4.0
docker compose down
docker compose up

# in a new terminal
mvn test

Can this be done without editing docker-compose.yml?

mr-c avatar Apr 13 '21 15:04 mr-c

A new compose file e.g docker-compose-test.yml can be created with the content of docker-compose.yml and the new changes. Then we can run docker compose -f docker-compose-test.yml up. This starts up the application with the contents of the test.yml thereby leaving docker-compose the way it is.

oceenachi avatar Apr 13 '21 20:04 oceenachi

A new compose file e.g docker-compose-test.yml can be created with the content of docker-compose.yml and the new changes.

It would be best to not "repeat ourselves" by having the same contents in two files, perhaps https://docs.docker.com/compose/extends/ has a hint?

mr-c avatar Apr 15 '21 10:04 mr-c

Okay, so the new test.yml shouldn't repeat all the contents rather it should just contain the new changes right ?

oceenachi avatar Apr 15 '21 10:04 oceenachi

Okay, so the new test.yml shouldn't repeat all the contents rather it should just contain the new changes right ?

Correct!

mr-c avatar Apr 15 '21 10:04 mr-c

Alright then. Thanks

oceenachi avatar Apr 15 '21 23:04 oceenachi

Hi @mr-c , can you talk about this task a bit more, I'm not certain I fully understand it so I haven't been able to work on it.

Secondly, Is the documentation here similar to the docs I wrote on #327.

I will also love to understand the difference between these yml files. a/docker-compose.yml b/docker-compose.yml.

oceenachi avatar Apr 20 '21 09:04 oceenachi

Hi @mr-c , can you talk about this task a bit more, I'm not certain I fully understand it so I haven't been able to work on it.

Secondly, Is the documentation here similar to the docs I wrote on #327.

I will also love to understand the difference between these yml files. a/docker-compose.yml b/docker-compose.yml.

I think what is required is a setup with adequate documentation that explains to users of this project the steps required to run tests without having to modify docker compose files that come with the project.

obasekiosa avatar Apr 20 '21 14:04 obasekiosa

Okay so it is similar to #327 right?

oceenachi avatar Apr 20 '21 14:04 oceenachi

Okay so it is similar to #327 right?

Yes it's actually very similar but not quite the same.

Without going too much into unnecessary detail. In this issue what's required is a docker compose configuration file that allows a user to connect and run all required tests. This "new" configuration file shouldn't be a duplicate of the configuration that already exists

https://docs.docker.com/compose/extends/

Note: something similar is already implemented in the project.

obasekiosa avatar Apr 20 '21 14:04 obasekiosa

Okay just a file is what is needed.

oceenachi avatar Apr 20 '21 14:04 oceenachi

Okay just a file is what is needed.

With adequate documentation.

You could choose to add the file yourself or give instructions on how to create and use such a file.

obasekiosa avatar Apr 20 '21 14:04 obasekiosa

okay thanks

oceenachi avatar Apr 20 '21 14:04 oceenachi

okay thanks

Keep in mind a criteria is to ensure docker-compose.yml is never edited manually.

obasekiosa avatar Apr 20 '21 14:04 obasekiosa

yea i already got that

oceenachi avatar Apr 20 '21 14:04 oceenachi

So I'm trying to run my tests on my local and all my graphiz tests are failing. Here is the error I am having and I don't know what I am missing

image

oceenachi avatar Apr 21 '21 22:04 oceenachi

So I'm trying to run my tests on my local and all my graphiz tests are failing. Here is the error I am having and I don't know what I am missing

image

Do you have graphviz installed?

And what os are you running on?

obasekiosa avatar Apr 21 '21 22:04 obasekiosa

No i don't have it installed

oceenachi avatar Apr 21 '21 22:04 oceenachi

No i don't have it installed

You have to install it.

obasekiosa avatar Apr 21 '21 22:04 obasekiosa

okay

oceenachi avatar Apr 21 '21 22:04 oceenachi