cwltool icon indicating copy to clipboard operation
cwltool copied to clipboard

Prov data input output

Open mr-c opened this issue 1 year ago • 4 comments

mr-c avatar Apr 03 '24 15:04 mr-c

Codecov Report

Attention: Patch coverage is 62.37624% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (c3bd4ca) to head (52b256b).

Files Patch % Lines
cwltool/cwlprov/ro.py 43.18% 20 Missing and 5 partials :warning:
cwltool/cwlprov/__init__.py 53.84% 6 Missing :warning:
cwltool/cwlprov/provenance_profile.py 40.00% 6 Missing :warning:
cwltool/cwlprov/writablebagfile.py 75.00% 0 Missing and 1 partial :warning:

:exclamation: There is a different number of reports uploaded between BASE (c3bd4ca) and HEAD (52b256b). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (c3bd4ca) HEAD (52b256b)
17 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1989       +/-   ##
===========================================
- Coverage   83.76%   70.08%   -13.69%     
===========================================
  Files          46       46               
  Lines        8262     8320       +58     
  Branches     2199     2114       -85     
===========================================
- Hits         6921     5831     -1090     
- Misses        861     1868     +1007     
- Partials      480      621      +141     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 15:04 codecov[bot]

@mr-c I think I fixed the code make cleanup could you have a look at the other tests? Not sure if they fail due to this implementation.

jjkoehorst avatar Apr 17 '24 06:04 jjkoehorst

@mr-c Hey! Would you review the --no-data --no-input implementation and give us some feedback if possible? Thanks! @

ElderMedic avatar Jul 22 '24 12:07 ElderMedic

Hey @ElderMedic ! I just started a vacation. I'll be back next week. Feel free to ping me again if you don't hear from me in 2 weeks.

mr-c avatar Jul 24 '24 06:07 mr-c