cwltool icon indicating copy to clipboard operation
cwltool copied to clipboard

Load schemas before calling print_deps

Open kinow opened this issue 3 years ago • 2 comments

Closes #1765

Unit test fails for main, and passes on this branch. The command from the issue reported also passes on this branch.

Cheers, -Bruno

kinow avatar Nov 18 '22 23:11 kinow

Codecov Report

:x: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.06%. Comparing base (67a1808) to head (2e5cc2e). :warning: Report is 362 commits behind head on main.

Files with missing lines Patch % Lines
cwltool/main.py 0.00% 2 Missing and 1 partial :warning:

:exclamation: There is a different number of reports uploaded between BASE (67a1808) and HEAD (2e5cc2e). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (67a1808) HEAD (2e5cc2e)
14 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1766       +/-   ##
===========================================
- Coverage   82.48%   54.06%   -28.42%     
===========================================
  Files          47       47               
  Lines        8181     8173        -8     
  Branches     2232     2074      -158     
===========================================
- Hits         6748     4419     -2329     
- Misses        939     3218     +2279     
- Partials      494      536       +42     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 18 '22 23:11 codecov[bot]

Hmmm, curious. I saw the tests failing, they are on the same test file that I used.

I picked the first test that failed for me, test_examples.py, test_trick_scandeps. I can confirm the command tested works on main, and fails on my branch.

However, cwltool --validate $file fails on both main and on this branch. So should a CWL file that fails validation, still be used on a unit test? The file is https://github.com/common-workflow-language/cwltool/blob/67a180835c001906cff4086963cd00ee99893498/tests/wf/trick_defaults.cwl

If so I will dig into the issue more and try to extract the part that loads the schemas from the resolve_and_validate_document function :+1:

kinow avatar Nov 19 '22 00:11 kinow