cwltool icon indicating copy to clipboard operation
cwltool copied to clipboard

Versioning with latest python libs

Open pjotrp opened this issue 5 years ago • 7 comments

These versions pass on my Guix build. You may need to edit some.

pjotrp avatar Dec 14 '18 02:12 pjotrp

Can one of the admins verify this patch?

cwl-bot avatar Dec 14 '18 02:12 cwl-bot

Codecov Report

Merging #1015 into master will decrease coverage by 26.26%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1015       +/-   ##
===========================================
- Coverage    79.2%   52.93%   -26.27%     
===========================================
  Files          30       30               
  Lines        5996     5996               
  Branches     1488     1488               
===========================================
- Hits         4749     3174     -1575     
- Misses        873     2411     +1538     
- Partials      374      411       +37
Impacted Files Coverage Δ
cwltool/singularity.py 22.66% <0%> (-57.34%) :arrow_down:
cwltool/provenance.py 27.86% <0%> (-52.54%) :arrow_down:
cwltool/executors.py 34.59% <0%> (-47.57%) :arrow_down:
cwltool/docker.py 17.56% <0%> (-36.94%) :arrow_down:
cwltool/builder.py 52.22% <0%> (-34.08%) :arrow_down:
cwltool/update.py 37.73% <0%> (-30.19%) :arrow_down:
cwltool/command_line_tool.py 47.8% <0%> (-30.08%) :arrow_down:
cwltool/job.py 37.3% <0%> (-30.03%) :arrow_down:
cwltool/workflow.py 61.08% <0%> (-23.65%) :arrow_down:
cwltool/process.py 63.55% <0%> (-22.55%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49cd284...e973ad3. Read the comment docs.

codecov[bot] avatar Dec 14 '18 06:12 codecov[bot]

Codecov Report

Merging #1015 into master will decrease coverage by 26.26%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1015       +/-   ##
===========================================
- Coverage    79.2%   52.93%   -26.27%     
===========================================
  Files          30       30               
  Lines        5996     5996               
  Branches     1488     1488               
===========================================
- Hits         4749     3174     -1575     
- Misses        873     2411     +1538     
- Partials      374      411       +37
Impacted Files Coverage Δ
cwltool/singularity.py 22.66% <0%> (-57.34%) :arrow_down:
cwltool/provenance.py 27.86% <0%> (-52.54%) :arrow_down:
cwltool/executors.py 34.59% <0%> (-47.57%) :arrow_down:
cwltool/docker.py 17.56% <0%> (-36.94%) :arrow_down:
cwltool/builder.py 52.22% <0%> (-34.08%) :arrow_down:
cwltool/update.py 37.73% <0%> (-30.19%) :arrow_down:
cwltool/command_line_tool.py 47.8% <0%> (-30.08%) :arrow_down:
cwltool/job.py 37.3% <0%> (-30.03%) :arrow_down:
cwltool/workflow.py 61.08% <0%> (-23.65%) :arrow_down:
cwltool/process.py 63.55% <0%> (-22.55%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49cd284...15539fb. Read the comment docs.

codecov[bot] avatar Dec 14 '18 06:12 codecov[bot]

Getting errors:

>       assert (master_run, PROV.wasAssociatedWith, engine) in g, "Wf run not associated with wf engine"
E       AssertionError: Wf run not associated with wf engine
E       assert (rdflib.term.URIRef(u'urn:uuid:ade29e98-83d3-44ec-88ec-5323bf95f29a'), rdflib.term.URIRef(u'http://www.w3.org/ns/prov#wasAssociatedWith'), rdflib.term.URIRef(u'urn:uuid:2a8057e9-aa75-4453-9dc4-101731822dc0')) in <Graph identifier=N0b510ca83152496fa728a8b8e97c8c18 (<class 'rdflib.graph.Graph'>)>
tests/test_provenance.py:410: AssertionError

mr-c avatar Dec 14 '18 07:12 mr-c

I have cwltool running with Python 3.7. Had to disable type_extensions with https://github.com/common-workflow-language/cwltool/pull/1015/commits/15539fba76993f951af9eba913bea6d677c74005

pjotrp avatar Dec 26 '18 13:12 pjotrp

@pjotrp Thanks for the update. How shall we proceed? We still support Python before 3.7, and your PR causes the tests to fail :-P

mr-c avatar Dec 26 '18 15:12 mr-c

Just leave the PR pending. Someone can add conditionals for a backport. I'll see if we can confirm the failing tests at some point. Dependency issues most likely. Python is a pain. I am happy I have a working version on Python 3.7. We'll start hammering it!

pjotrp avatar Dec 26 '18 15:12 pjotrp