common-voice icon indicating copy to clipboard operation
common-voice copied to clipboard

[BUG] 1 untranslated string (donating one sentence and no citation) (de)

Open robovoice1 opened this issue 1 year ago • 3 comments

Describe the bug A clear and concise description of what the bug is.

If the contributer donates a single sentence (non en) without the citation and submit the sentence, the info "Please fill out this field" pops up (not translated)

To Reproduce Steps to reproduce the behavior:

  1. write a sentence in a non english language
  2. Leave the citation field blank
  3. Submit the sentence
  4. See the not translated info

Expected behavior A clear and concise description of what you expected to happen. Translated message

Screenshots If applicable, add screenshots to help explain your problem. Screenshot_20240915-112018

Mobile (please complete the following information):

  • OS: [e.g. iOS] GrapheneOS
  • Browser [e.g. chrome, safari] Vanadium
  • Version [e.g. 22] 128.0.6613.146

robovoice1 avatar Sep 15 '24 09:09 robovoice1

I tested this on a local development version of Common Voice version 137.7 and was unable to replicate.

  1. Go to German sentence contribution page
  2. Add in a sentence without a citation
  3. Submit the sentence

The Tooltip shown is in German, not English.

Image

@robovoice1 can you please confirm if this is still occurring for you? It may only be occurring on the mobile version....

moz-kathyreid avatar Mar 05 '25 10:03 moz-kathyreid

I think we found a very interesting thing. A couple of months ago, while merging with MCV:SS strings, the strings were divided into files and that string should be in write.ftl - and it is.

The actual string is:

required-field = Bitte füllen Sie dieses Feld aus.

On the other hand, the files under de seem not be handled correctly. The older files messages.ftl and cross-locale.ftl are still there.

I checked, it is only for de. Maybe a script got terminated while handling this.

I think it was a transient bug where the new files were not accumulated, but later fixed. On the other hand we have two zombie files which should be deleted (please add to the deletions list: Japanese sentences at the root folder).

HarikalarKutusu avatar Mar 05 '25 12:03 HarikalarKutusu

Thanks as always @HarikalarKutusu - appreciated.

Next steps for this one:

  • Remove messages.ftl and cross-locale.ftl for de
  • Remove Japanese sentences at the root level

(I am doing a sweep of open Issues, will come back to this)

moz-kathyreid avatar Mar 06 '25 08:03 moz-kathyreid