common-voice icon indicating copy to clipboard operation
common-voice copied to clipboard

Links to specific FAQ items don't work

Open Yorwba opened this issue 2 years ago • 2 comments

There are some links to the FAQ that use the hash fragment to point to a specific FAQ item, but because the FAQ is rendered client-side, there is no element with a matching ID on page load, so the default browser behavior of scrolling to the given element doesn't trigger.

To Reproduce Steps to reproduce the behavior:

  1. Go to the languages page.
  2. Click on the links "website localization" or "sentence collection" in the "In Progress" section.
  3. A loading animation is displayed and then the FAQ page shows up partially scrolled.
  4. Note that no content directly related to the link text is visible at first sight.

Expected behavior Clicking the links should lead to a page explaining the processes of website localization and sentence collection, respectively. So at the very least the correct FAQ entry should be visible.

(I kind of feel like that isn't quite enough because the FAQ only briefly explains the meaning of the term, but doesn't give any information about becoming involved and helping out with the process. But maybe that's out of scope for this issue.)

Desktop

  • OS: Ubuntu 21.04
  • Browser: Firefox
  • Version 98.0.2

Additional context After using the back button and clicking on the link again, the correct FAQ entry scrolls into view. So it seems like the functionality is there in principle, but doesn't trigger on first load.

Yorwba avatar Mar 27 '22 20:03 Yorwba

Thank you @Yorwba, this is very useful. I separately noticed some of this was broken so will be sure to try and fix this.

zcolleyz avatar Mar 29 '22 15:03 zcolleyz

And I agree on the FAQs, we're going to be changing that copy soon I think - although going to focus on the navigation bug here when addressing this issue.

zcolleyz avatar Mar 29 '22 15:03 zcolleyz