commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

changelog_incremental is set as default when calling changelog from cz bump

Open LuisHenri opened this issue 2 years ago • 2 comments

Description

cz bump with changelog_incremental = false on pyproject.toml doesn't have any effect when calling cz bump --changelog or cz bump with update_changelog_on_bump = true`.

Steps to reproduce

  1. Define changelog_incremental = false and update_changelog_on_bump = true
  2. Run cz bump

Current behavior

It runs as if changelog_incremental = true.

Desired behavior

Run cz ch without incremental.

Screenshots

image https://github.com/commitizen-tools/commitizen/blob/9d0878c201c579aaf7d7c0219f19f95897bd01fc/commitizen/commands/bump.py#L272C1-L279C14

Environment

Commitizen Version: 3.10.0
Python Version: 3.8.10 (tags/v3.8.10:3d8993a, May  3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]
Operating System: Windows

LuisHenri avatar Oct 11 '23 14:10 LuisHenri

Hi @LuisHenri , thanks for reporting this issue. I've verified this is indeed a valid bug.

Lee-W avatar Oct 17 '23 13:10 Lee-W

We'd appreciate it if you're interested in sending us a PR. 🙂 I think this should be an easy and small one. Other than the value change, all we need is adding a few tests

Lee-W avatar Oct 17 '23 13:10 Lee-W