commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

feat: Ignore fixup! & squash!

Open a5r0n opened this issue 3 years ago • 2 comments

Description

#414

Checklist

  • [x] Add test cases to all the changes you introduce
  • [ ] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [ ] Test the changes on the local machine manually
  • [ ] Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

a5r0n avatar Aug 08 '22 22:08 a5r0n

Codecov Report

Merging #551 (ca35a55) into master (ed636ba) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage   98.26%   98.32%   +0.05%     
==========================================
  Files          39       39              
  Lines        1556     1551       -5     
==========================================
- Hits         1529     1525       -4     
+ Misses         27       26       -1     
Flag Coverage Δ
unittests 98.32% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/commands/check.py 100.00% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/cmd.py 100.00% <100.00%> (ø)
commitizen/git.py 100.00% <100.00%> (ø)
commitizen/changelog.py 100.00% <0.00%> (+0.56%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Aug 08 '22 22:08 codecov[bot]

Disclaimer: I am not a maintainer.

I wonder what happens to the changelog if you forget to rebase these out of existence. Is it (correctly) ignoring them?

bhelgs avatar Aug 10 '22 16:08 bhelgs

the validate_commit_message called only when u run cz check (like the pre-commit do). so i think the changelog be not impacted.

a5r0n avatar Aug 12 '22 10:08 a5r0n

Could be possible to load the prefixes to ignore from the config file? I'm thinking that Merge, Revert, fixup! are quite standard but they may not fit in any project and a simple solution could load the prefixes from a file (leaving the current prefixes Merge, Revert and so on as default).

What do you think?

eldipa avatar Aug 16 '22 21:08 eldipa

Hi @eldipa , I think that's a good idea! But I wish to keep this PR as it is. We could create another issue / PR for tracking the feature you mention. Thanks!

Lee-W avatar Aug 20 '22 07:08 Lee-W

@woile I'm thinking of merging this one this week. Please let me know if we need more discussion on this one :)

Lee-W avatar Sep 19 '22 13:09 Lee-W