feat: Ignore fixup! & squash!
Description
#414
Checklist
- [x] Add test cases to all the changes you introduce
- [ ] Run
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and test - [ ] Test the changes on the local machine manually
- [ ] Update the documentation for the changes
Expected behavior
Steps to Test This Pull Request
Additional context
Codecov Report
Merging #551 (ca35a55) into master (ed636ba) will increase coverage by
0.05%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
+ Coverage 98.26% 98.32% +0.05%
==========================================
Files 39 39
Lines 1556 1551 -5
==========================================
- Hits 1529 1525 -4
+ Misses 27 26 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 98.32% <100.00%> (+0.05%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| commitizen/commands/check.py | 100.00% <ø> (ø) |
|
| commitizen/__version__.py | 100.00% <100.00%> (ø) |
|
| commitizen/cmd.py | 100.00% <100.00%> (ø) |
|
| commitizen/git.py | 100.00% <100.00%> (ø) |
|
| commitizen/changelog.py | 100.00% <0.00%> (+0.56%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us.
Disclaimer: I am not a maintainer.
I wonder what happens to the changelog if you forget to rebase these out of existence. Is it (correctly) ignoring them?
the validate_commit_message called only when u run cz check (like the pre-commit do).
so i think the changelog be not impacted.
Could be possible to load the prefixes to ignore from the config file? I'm thinking that Merge, Revert, fixup! are quite standard but they may not fit in any project and a simple solution could load the prefixes from a file (leaving the current prefixes Merge, Revert and so on as default).
What do you think?
Hi @eldipa , I think that's a good idea! But I wish to keep this PR as it is. We could create another issue / PR for tracking the feature you mention. Thanks!
@woile I'm thinking of merging this one this week. Please let me know if we need more discussion on this one :)