commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

generate defaults for cz_customize pyproject.toml

Open willjhenry opened this issue 3 years ago • 10 comments

Description

I want to add a type but, in order to do so, I need to define the entire commitizen sections of my pyproject.toml as outlined here: https://commitizen-tools.github.io/commitizen/customization/.

It would be much easier to have the option to start with the defaults filled in (e.g. default questions, default message_template,etc...) and then modify from there. As it is now, I am copying values out of the ConventionalCommitsCz

Possible Solution

No response

Additional context

No response

Additional context

No response

willjhenry avatar Jul 05 '22 19:07 willjhenry

What's in my mind was making cz_conventional_commits configurable and deprecate cz_customize? What do you think?

Lee-W avatar Jul 22 '22 15:07 Lee-W

Yeah, that sounds good to me!

On Jul 22, 2022, at 8:14 AM, Wei Lee @.***> wrote:

What's in my mind was making cz_conventional_commits configurable and deprecate cz_customize? What do you think?

— Reply to this email directly, view it on GitHub https://github.com/commitizen-tools/commitizen/issues/535#issuecomment-1192676349, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP2QC2WN5OBWM2RD7FRRXLVVK3FFANCNFSM52XGQHMA. You are receiving this because you authored the thread.

willjhenry avatar Jul 22 '22 15:07 willjhenry

Actually, thinking about it a bit more. I think that is good however, we’d still need to define all of the types, if we just wanted to add a type. So it would be good to have default config template to start from. Maybe that is what you are thinking?

On Jul 22, 2022, at 8:14 AM, Wei Lee @.***> wrote:

What's in my mind was making cz_conventional_commits configurable and deprecate cz_customize? What do you think?

— Reply to this email directly, view it on GitHub https://github.com/commitizen-tools/commitizen/issues/535#issuecomment-1192676349, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP2QC2WN5OBWM2RD7FRRXLVVK3FFANCNFSM52XGQHMA. You are receiving this because you authored the thread.

willjhenry avatar Jul 22 '22 15:07 willjhenry

either way works for me. 🙂 we're kinda out of bandwidth these days. would be great if you're interested in sending a PR

Lee-W avatar Jul 22 '22 15:07 Lee-W

@Lee-W Hi, I would like to try and open a PR making cz_conventional_commits read from config and then fallback to defaults, allowing extensibility without the need to specify all configuration for cz_customize if we just want to override small behavior. Is that ok from your side?

amitlevy21 avatar Aug 03 '22 10:08 amitlevy21

@Lee-W I took the initiative and opened a PR. Hope it's ok and curios to hear your thoughts

amitlevy21 avatar Aug 03 '22 13:08 amitlevy21

Thanks @amitlevy21 . Will take a deeper look these days!

Lee-W avatar Aug 04 '22 02:08 Lee-W

@Lee-W @amitlevy21 any updates to use cz_customize with default parser ?

shantonio avatar Jun 26 '23 18:06 shantonio

No update at this moment. Would appreciate it if anyone wants to take a look 🙂

Lee-W avatar Jun 27 '23 02:06 Lee-W