`cz changelog` is not reporting git errors (`git.py` missing `cmd.return_code` checks)
Description
cz commit worked just fine, but cz changelog resulted in the error:
"No commits found"
I later came to find the calls to git were silently failing in git.get_tags due to an unsupported version of git.
It's not very obvious the issue is with git.
Might we want some kind of warnings/exceptions here"?
Steps to reproduce
- unsupported git (e.g. 1.8.3.1) (normally we use a newer version)
cz changelog(cz commitworked)
Current behavior
Error handling could be improved.
Desired behavior
Maybe a warning or raise would help users out when cmd.run( ...git...) fails?
Screenshots
No response
Environment
CentOS7
If you'd like to see a PR just let me know if/what you'd like. I've already made a few cz alterations for my teams anyway.
Sorry for the late reply. Yep, this is something we missed. Would be great if you're interested in sending a PR 🙂
Sounds good. No problem.