fix semver not fully covered
Description
Related issue: #950
Checklist
- [ ] I have read the contributing guidelines
- [ ] Better/correct test cases
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 98.25%. Comparing base (120d514) to head (bb48144).
:warning: Report is 805 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
+ Coverage 97.33% 98.25% +0.91%
==========================================
Files 42 58 +16
Lines 2104 2696 +592
==========================================
+ Hits 2048 2649 +601
+ Misses 56 47 -9
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 98.25% <100.00%> (+0.91%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
I will update this PR this week when I have bandwidth
Maybe we can adjust the workflow. Several PRs got closed just because the target branch is deleted
Yep, this was a temporary workflow. we usually don't receive this many PR and don't review this fast. Maybe worth rethink it to make a rc to avoid what we encountered yesterday as well