commitizen
commitizen copied to clipboard
fix mypy warning and enforce it in scripts
After running mypy locally, I found there are type errors and even some logic errors. Since we already have type hint in our project, it seems to be better if we can fix them now.
Plan
- [x] Step 1. Fix current type error and logic errors
- [x] Step 2. Enforce mypy type check on GitHub Action
- [ ] Step 3. Introduce a stricter
mypyconfig and remove vague type likeAny
Step 1 and 2 is done by #156
mypy is strict enough I think, please reopen if otherwise
Sounds good 👍