commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

fix mypy warning and enforce it in scripts

Open Lee-W opened this issue 5 years ago • 1 comments

After running mypy locally, I found there are type errors and even some logic errors. Since we already have type hint in our project, it seems to be better if we can fix them now.

Plan

  • [x] Step 1. Fix current type error and logic errors
  • [x] Step 2. Enforce mypy type check on GitHub Action
  • [ ] Step 3. Introduce a stricter mypy config and remove vague type like Any

Lee-W avatar Apr 08 '20 09:04 Lee-W

Step 1 and 2 is done by #156

Lee-W avatar Apr 24 '20 10:04 Lee-W

mypy is strict enough I think, please reopen if otherwise

woile avatar Apr 28 '23 10:04 woile

Sounds good 👍

Lee-W avatar May 06 '23 10:05 Lee-W