feat(commands)!: deprecate '-s' signoff parameter
Description
feat(commands)!: deprecate '-s' signoff parameter
Follow-up to #1206, deprecating -s for major v4.
Checklist
- [x] Add test cases to all the changes you introduce
- [x] Run
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and test - [x] Test the changes on the local machine manually
- [x] Update the documentation for the changes
Expected behavior
Steps to Test This Pull Request
Additional context
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
v4@737c24c). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## v4 #1221 +/- ##
=====================================
Coverage ? 97.61%
=====================================
Files ? 55
Lines ? 2515
Branches ? 0
=====================================
Hits ? 2455
Misses ? 60
Partials ? 0
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 97.61% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Though implemented per request towards v4, I vote against my own PR,
because some of my teams' developers use it all the time as this is considered "basic" / "normal" usage.
Though implemented per request towards v4, I vote against my own PR, because some of my teams' developers use it all the time as this is considered "basic" / "normal" usage.
I'm ok to keep a few exceptions. As long as the underlying logic is not duplicate and the document is suggesting using --
Deprecation of -s canceled for commitizen v4 :+1: