commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

feat(commands)!: deprecate '-s' signoff parameter

Open AdrianDC opened this issue 1 year ago • 1 comments

Description

feat(commands)!: deprecate '-s' signoff parameter

Follow-up to #1206, deprecating -s for major v4.

Checklist

  • [x] Add test cases to all the changes you introduce
  • [x] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [x] Test the changes on the local machine manually
  • [x] Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

AdrianDC avatar Aug 25 '24 00:08 AdrianDC

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v4@737c24c). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v4    #1221   +/-   ##
=====================================
  Coverage      ?   97.61%           
=====================================
  Files         ?       55           
  Lines         ?     2515           
  Branches      ?        0           
=====================================
  Hits          ?     2455           
  Misses        ?       60           
  Partials      ?        0           
Flag Coverage Δ
unittests 97.61% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 00:08 codecov[bot]

Though implemented per request towards v4, I vote against my own PR,
because some of my teams' developers use it all the time as this is considered "basic" / "normal" usage.

AdrianDC avatar Nov 01 '24 17:11 AdrianDC

Though implemented per request towards v4, I vote against my own PR, because some of my teams' developers use it all the time as this is considered "basic" / "normal" usage.

I'm ok to keep a few exceptions. As long as the underlying logic is not duplicate and the document is suggesting using --

Lee-W avatar Nov 02 '24 05:11 Lee-W

Deprecation of -s canceled for commitizen v4 :+1:

AdrianDC avatar Nov 04 '24 23:11 AdrianDC