commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

Shows deprecated warning before prompt questions

Open marcosdotme opened this issue 1 year ago • 3 comments

Description

Shows deprecated warning before prompt questions to dev, for an better experience.

Checklist

  • [x] Add test cases to all the changes you introduce
  • [x] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [x] Test the changes on the local machine manually
  • [x] Update the documentation for the changes (deprecated warning already in docs)

Screenshots

Shows deprecated warning before prompt questions

image

Shows deprecated warning on command help text

image

Dont' shows deprecated warning if uses --signoff option the right way

image

marcosdotme avatar May 28 '24 18:05 marcosdotme

Relates to #1135

marcosdotme avatar May 28 '24 18:05 marcosdotme

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.54%. Comparing base (120d514) to head (22d6d7e). Report is 526 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   97.33%   97.54%   +0.20%     
==========================================
  Files          42       55      +13     
  Lines        2104     2486     +382     
==========================================
+ Hits         2048     2425     +377     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.54% <100.00%> (+0.20%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '24 18:05 codecov[bot]

Would it be possible for us to also document the -- behavior in help text 🤔

Of course. I will add this too

marcosdotme avatar Jun 03 '24 14:06 marcosdotme