commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

Fix semver not fully covered

Open Lee-W opened this issue 1 year ago • 6 comments

Description

1.0.0-reallyweird is a valid semver but not yet covered by commitizen. Possible solution could be https://github.com/commitizen-tools/commitizen/issues/950#issuecomment-2072666867

Closes: #950

Checklist

  • [ ] Add test cases to all the changes you introduce
  • [ ] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [ ] Test the changes on the local machine manually
  • [ ] Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

Lee-W avatar Apr 24 '24 02:04 Lee-W

Currently, only test cases are added. Will need to find some time to wrap it up. Feel free to take over if anyone's interested in it 🙂

Lee-W avatar Apr 24 '24 02:04 Lee-W

I think this one would be a bit tricky 🤔 prerelease can be anything for semver. Thus, bump prerelease might not make sense to semver. e.g., what should be the next version of 1.1.0-test @woile @noirbizarre WDYT?

Lee-W avatar Apr 25 '24 14:04 Lee-W

I completely missed this. I don't know the answer, but I think we could stick to adding the 0 at the end (?)

1.1.0-test.0
1.1.0-test.1
1.1.0-test.2

Similar to semver:

1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1

And we could assume anything unknown is before alpha (?)

woile avatar Sep 12 '24 12:09 woile