commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

mypy improvement

Open Lee-W opened this issue 1 year ago • 1 comments

Description

This is part of https://github.com/commitizen-tools/commitizen/issues/1053, which intends to catch errors earlier through a more strict mypy setting.

Checklist

  • [x] Add test cases to all the changes you introduce
  • [x] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [x] Test the changes on the local machine manually
  • [x] Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

#1053

Lee-W avatar Apr 05 '24 15:04 Lee-W

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.57%. Comparing base (120d514) to head (06eef86). Report is 413 commits behind head on master.

Files Patch % Lines
commitizen/commands/check.py 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   97.33%   97.57%   +0.23%     
==========================================
  Files          42       55      +13     
  Lines        2104     2518     +414     
==========================================
+ Hits         2048     2457     +409     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.57% <95.00%> (+0.23%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 05 '24 16:04 codecov[bot]