ui-kit icon indicating copy to clipboard operation
ui-kit copied to clipboard

Rethinking Theming support

Open emmenko opened this issue 4 years ago • 2 comments

We should also probably rethink a bit how we plan and want to continue support theming. At the moment is more of a "hidden" feature but we do rely on it in other places. It's also not super consistent as only a bunch of components support that.

Apparently, in some recent emotion updates there have been some "regressions" (#1660 and https://github.com/commercetools/commercetools-docs-kit/pull/745) which forces us to fix that here.

I think we need to make a decision how we want to continue the theming support.

PS: have a read at https://epicreact.dev/css-variables/ as an inspiration for an alternative approach (assuming it would be possible in our setup).

emmenko avatar Nov 09 '20 11:11 emmenko

Has any discussion happened regarding this?

bradd123 avatar Mar 01 '21 18:03 bradd123

Nope. It hasn't been a priority and we do not need it ourselves at the moment.

tdeekens avatar Mar 01 '21 19:03 tdeekens