commercetools-sdk-java-v2 icon indicating copy to clipboard operation
commercetools-sdk-java-v2 copied to clipboard

Add dynatrace monitoring module

Open lojzatran opened this issue 10 months ago • 1 comments

I added same metrics as in other monitoring modules. Example app for this: https://github.com/commercetools/commercetools-sdk-java-v2/pull/623

lojzatran avatar Apr 15 '24 12:04 lojzatran

Codecov Report

Attention: Patch coverage is 3.60360% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 10.59%. Comparing base (29dd4b3) to head (fe8e20e).

Files Patch % Lines
...itoring/dynatrace/DynatraceResponseSerializer.java 0.00% 61 Missing :warning:
...toring/dynatrace/DynatraceTelemetryMiddleware.java 0.00% 45 Missing :warning:
...mercetools/monitoring/dynatrace/DynatraceInfo.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #622      +/-   ##
============================================
- Coverage     10.60%   10.59%   -0.02%     
- Complexity     1842     1843       +1     
============================================
  Files          6220     6224       +4     
  Lines         59405    59516     +111     
  Branches        265      267       +2     
============================================
+ Hits           6299     6303       +4     
- Misses        52941    53048     +107     
  Partials        165      165              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 15 '24 12:04 codecov[bot]

We decided not to add dynatrace module for now.

Reason: it would add too much overhead as it uses HTTP to create new metrics. This would significantly slow down every request to commercetools. The other way for now for dynatrace is to use opentelemetry.

lojzatran avatar Apr 22 '24 12:04 lojzatran