commercetools-jvm-sdk icon indicating copy to clipboard operation
commercetools-jvm-sdk copied to clipboard

TaxRate to BigDecimal?

Open schleichardt opened this issue 8 years ago • 3 comments

@lauraluiz what do you think? http://sphereio.github.io/sphere-jvm-sdk/apidocs/io/sphere/sdk/taxcategories/TaxRate.html#getAmount--

schleichardt avatar Mar 14 '16 15:03 schleichardt

In case of doubt I always use BigDecimal, especially since it is normal to do mathematical operations with the taxes, so yes from my side :+1:

lauraluiz avatar Mar 18 '16 10:03 lauraluiz

I will add another method to stay compatible with current sdk users.

schleichardt avatar Mar 31 '16 13:03 schleichardt

I would prefer to change the getAmount method to return BigDecimal instead of Double. That's a breaking change, but as suggested by Michael we could add another method getAmountAsDouble to make it easier to migrate existing code.

katmatt avatar Apr 27 '17 08:04 katmatt