commenthol

Results 64 comments of commenthol

PR #262 should fix this issue

@nicjansma Thanks for your proposals. The purpose of this library is to parse the User-Agent Header and returns information on Browser, OS, and brand model. It is unaware of the...

HI @nicjansma , Happy to hear that the proposed is well received. Yes please feel free to create a PR with your recommendations on how clients might use uap-core together...

@nitayk Can you please create a PR?

@gjdonkers This PR conflicts with #286. Is this still valid?

@sgrayson21 Could you please provide a testcase with this PR?

@mayanksourabh What do you expect as a value instead?

@wallin Thanks for your PR. I think that the regex without your changes should also work.

What would you expect as parsing result? Just ua.family = CaptiveNetworkSupport?