commandline icon indicating copy to clipboard operation
commandline copied to clipboard

IL2104: Assembly 'CommandLine' produced trim warnings

Open felipeogarcia opened this issue 2 years ago • 0 comments

I'm getting an error message indicating the library is using a method that is incompatible with application trimming.

From what I can see, the specific issue is with the System.ComponentModel.TypeDescriptor.GetConverter method. Generic TypeConverters may require the generic types to be annotated. An option would be to use GetConverterTrimUnsafe if we can be sure the converter is trim compatible (type is not Nullable<T>).

// CommandLine.Core.TypeConverter.ConvertString
private static object ConvertString(string value, Type type, CultureInfo conversionCulture)
{
    try
    {
        return Convert.ChangeType(value, type, conversionCulture);
    }
    catch (InvalidCastException)
    {
        // Required for converting from string to TimeSpan because Convert.ChangeType can't
        return System.ComponentModel.TypeDescriptor.GetConverter(type).ConvertFrom(null, conversionCulture, value);
    }
}

felipeogarcia avatar Mar 10 '22 19:03 felipeogarcia