WheelPickerCompose icon indicating copy to clipboard operation
WheelPickerCompose copied to clipboard

Support for other calendars

Open ahmad-shoja opened this issue 2 years ago • 12 comments

Hi, i think we can support other calendar systems by adding another parameter like "dateSystem". I don't think it requires much changes. Just adding corresponding year-range, months and days range

ahmad-shoja avatar Dec 20 '22 18:12 ahmad-shoja

Hi, @ahmad-shoja thanks for your feedback. Really can be useful, but which calendars we can add?

commandiron avatar Dec 21 '22 06:12 commandiron

To start we can add jallali calendar as I need but there are more systems out there that we can choose popular ones from

ahmad-shoja avatar Dec 21 '22 07:12 ahmad-shoja

Hi, please assign this issue to me I can add this feature.

ahmad-shoja avatar Dec 22 '22 12:12 ahmad-shoja

hi, can't u create pull-request for this?

commandiron avatar Dec 22 '22 14:12 commandiron

yeah, why not , I'll create pull-request

ahmad-shoja avatar Dec 22 '22 15:12 ahmad-shoja

this branch is created for this issue.

commandiron avatar Dec 28 '22 20:12 commandiron

@ahmad-shoja hi. i can't import PersianDate class for a reason I don't know

commandiron avatar Dec 28 '22 20:12 commandiron

Hi @commandiron did you add it's dependency in build gradle file ?

ahmad-shoja avatar Dec 29 '22 02:12 ahmad-shoja

@ahmad-shoja "saman.zamani.persiandate.PersianDate" this import seems to not correct. I don't understand why. Can u bury this code into the package instead of using library?

commandiron avatar Dec 29 '22 11:12 commandiron

Hi, Can you tell what is the problem specifically? And where do you get stock ?

ahmad-shoja avatar Dec 29 '22 11:12 ahmad-shoja

I buried the library inside the code, please check it out

ahmad-shoja avatar Dec 30 '22 20:12 ahmad-shoja

Hi @commandiron, I pushed my new commits but I can't see them in your development_jalalian_calendar, I'm wondering if i need to open a new pull request or what?

ahmad-shoja avatar Jan 01 '23 19:01 ahmad-shoja