commander icon indicating copy to clipboard operation
commander copied to clipboard

dotfiles in test dir cause a panic

Open taigrr opened this issue 1 year ago • 1 comments

Prerequisites

  • [X ] Can you reproduce the problem?
  • [X ] Are you running the latest version?
  • [X ] Did you perform a cursory search?

Description

Using latest release on macos, the --dir tests cause the binary to panic because a non-yaml file, .DS_Store, exists in the directory. This also happens if there's a .gitignore or .gitattributes file present.

Steps to Reproduce

  1. Create a testing dir
  2. add a non-yaml dotfile to the directory
  3. test using --dir
  4. observe the binary panic

Expected behavior: the binary should skip hidden files

Actual behavior: the binary does not skip hidden files, and panics

Specifications

  • Version: 2.5.0
  • Platform: All

taigrr avatar Nov 02 '23 05:11 taigrr

thanks to @jscottsf for pointing out this bug to me

taigrr avatar Nov 02 '23 07:11 taigrr