openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

2024 IONIQ 6

Open riley-williams opened this issue 10 months ago • 1 comments

Car

US 2024 IONIQ 6 (Limited AWD tested)

Checklist

  • [x] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [ ] test route added to routes.py
  • [ ] route with openpilot:
  • [ ] route with stock system:
  • [x] car harness used: Hyundai P

Notes

  • Minor tweaks to CarSpecs for IONIQ 6 reflect public info instead of cloning the subtly different IONIQ 5 specs
  • Both model years have identical fingerprints, and the '24 is currently ID'd as a '23. The marketing materials for the two model years also seem to have no differences.

riley-williams avatar Apr 27 '24 00:04 riley-williams

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Apr 27 '24 00:04 github-actions[bot]

This good to go?

sshane avatar May 22 '24 00:05 sshane

I don't see any 2024s in our data, but a lot of routes are missing the VIN due to some issue in the comma power (we should figure out how to get the VIN without that). Do you have a route of a 2024?

sshane avatar May 22 '24 03:05 sshane

@sshane apologies for the slow progress getting these recorded. Added routes with and without openpilot. The without is unfortunately not very long, so I can get another if needed

riley-williams avatar May 26 '24 16:05 riley-williams

Also not sure if you want this added to routes.py since there is already a route for the (identical?) 2023 model. Looking at the file, it seems like the list is being kept as short as possible.

riley-williams avatar May 26 '24 16:05 riley-williams

Interesting that the 2024 uses the same FW from our first port: https://github.com/commaai/openpilot/pull/28915

LGTM:

Dongle, platform, VIN Name from VIN 🆚 CarDocs Segments Bad seg tags Good seg tags
3ff5830d2216f742
HYUNDAI_IONIQ_6
000000000........
None 🆚
None
43 routes,
968 segments
(16.1 hours)
- spotty FW: 47 - valid torque params: 959
- all lat active: 501
- no input all lat active: 112

sshane avatar Jun 05 '24 21:06 sshane